Do not allow changes to OTLP exporter configuration after instantiation #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3066 +/- ##
==========================================
+ Coverage 84.70% 84.71% +0.01%
==========================================
Files 259 259
Lines 9119 9121 +2
==========================================
+ Hits 7724 7727 +3
+ Misses 1395 1394 -1
|
cijothomas
approved these changes
Mar 18, 2022
reyang
reviewed
Mar 18, 2022
| #if NETSTANDARD2_1 || NET5_0_OR_GREATER | ||
| internal GrpcChannel Channel { get; set; } | ||
| #else | ||
| internal Channel Channel { get; set; } | ||
| #endif | ||
|
|
||
| internal Uri Endpoint { get; } |
There was a problem hiding this comment.
never mind, I see that it only has "get"
reyang
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the underlying HTTP and gRPC export clients kept a handle on the original
OtlpExporterOptionsinstance. This allowed for the options to change thereby allowing the behavior of an OTLP exporter instance to be altered after it's been instantiated.